Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: get rid of AstCommentValue in AST #1664

Merged
merged 4 commits into from
Jan 31, 2025
Merged

refactor: get rid of AstCommentValue in AST #1664

merged 4 commits into from
Jan 31, 2025

Conversation

i582
Copy link
Contributor

@i582 i582 commented Jan 31, 2025 •
edited
Loading

Issue

Closes #1661.

Checklist

  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@i582 i582 added this to the v1.6.0 milestone Jan 31, 2025
@i582 i582 requested a review from a team as a code owner January 31, 2025 16:27
verytactical
verytactical reviewed Jan 31, 2025
View reviewed changes
src/ast/util.ts Outdated Show resolved Hide resolved
verytactical
verytactical previously approved these changes Jan 31, 2025
View reviewed changes
@anton-trunov anton-trunov merged commit 45f3e35 into main Jan 31, 2025
24 checks passed
@anton-trunov anton-trunov deleted the pmakhnev/as-comment-in-intepreter branch January 31, 2025 17:30
sansx pushed a commit to TownSquareXYZ/tact that referenced this pull request Feb 10, 2025
@i582 @sansx
refactor: get rid of AstCommentValue in AST (tact-lang#1664)
41b94dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verytactical verytactical verytactical left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Get rid of AstCommentValue in AST
3 participants
@i582 @verytactical @anton-trunov