Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove "remainder" from error messages and TL-B schemes #1699

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: remove "remainder" from error messages and TL-B schemes #1699

wants to merge 6 commits into from
+22 −21

Conversation

i582
Copy link
Contributor

@i582 i582 commented Feb 4, 2025 •
edited
Loading

Issue

Closes #1636.

Checklist

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@i582 i582 added this to the v1.6.0 milestone Feb 4, 2025
@i582 i582 requested a review from a team as a code owner February 4, 2025 13:52
novusnota
novusnota previously approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@novusnota novusnota left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"MTGL".split('').reverse().join('')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novusnota novusnota novusnota left review comments

@anton-trunov anton-trunov Awaiting requested review from anton-trunov

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Remove "remainder" from error messages and TL-B schemes
2 participants
@i582 @novusnota