Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep fewer logs around #26

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Keep fewer logs around #26

merged 3 commits into from
Feb 5, 2025

Conversation

hacklschorsch
Copy link
Member

Refs #17

Copy link
Member

@btlogy btlogy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll also back port those change here:

services.journald.extraConfig = ''
SystemMaxUse=500M
'';

btlogy added a commit that referenced this pull request Jan 29, 2025
Co-authored-by: Florian Sesser <florian@leastauthority.com>
Signed-off-by: Benoit Donneaux <benoit@leastauthority.com>
@hacklschorsch
Copy link
Member Author

@btlogy I am won't be including our global defaults in the test grid definition - I want this to stand on its own (as an example for someone else wanting to stand up a grid like this). OK?

@hacklschorsch hacklschorsch merged commit bd9564d into main Feb 5, 2025
@hacklschorsch hacklschorsch deleted the 17.fewer-logs branch February 5, 2025 14:33
@btlogy
Copy link
Member

btlogy commented Feb 5, 2025

@btlogy I am won't be including our global defaults in the test grid definition - I want this to stand on its own (as an example for someone else wanting to stand up a grid like this). OK?

I'm not sure to see much value into keeping it on its own. But this will lead to repetitions.
Also, it a contributor likes the testgrid the way we propose to manage all other system, it will be easier for him to PR for other systems too.
I know you like to keep things contained as much as possible. We can always change this later if it hurts.

But than I wonder how much contained: no flake, no CI and no CD for testgrid?
Maybe we should have a repository for each system then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants