Feat: Too small buffer size for data transmission and rdb read-write #896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugs
func (r *syncStandaloneReader) receiveRDB() string
pass a writer instead of a BufferWriter when callreceiveRDBWithoutDiskless
func (r *syncStandaloneReader) receiveRDBWithoutDiskless(marker string, wt io.Writer)
use 32MBbuf
to buffer tcp data before every write to file, and hoping to callWrite
function once every 32M cycles.bufio.Reader
is 4096, so each call ofr.rd.Read(buf[:readOnce])
can only return up to 4k data, and then will callWrite
function and write to FileFix
func (r *syncStandaloneReader) receiveRDBWithoutDiskless(marker string, wt io.Writer)