fix: add base node proto to fix compile error #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnaveira
approved these changes
Jan 16, 2024
Merged
via the queue into
tari-project:development
with commit Jan 16, 2024
9d1ebb4
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds base node proto to common_types to fix compile error
removes tari_comms from common deps and adds them to integration_tests crate
Motivation and Context
tari_core fails to compile without base_node_proto. This happens in transaction_generator. This issue might be fixed in the features-dan2 PR
How Has This Been Tested?
transaction_generator compiles
What process can a PR reviewer use to test or verify this change?
transaction_generator compiles
Breaking Changes