Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use workspace version #6279

Merged

Conversation

stringhandler
Copy link
Collaborator

Description

Use workspace version for more consistent versioning

@stringhandler stringhandler requested a review from a team as a code owner April 15, 2024 10:33
@ghpbot-tari-project ghpbot-tari-project added the CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. label Apr 15, 2024
sdbondi
sdbondi previously approved these changes Apr 15, 2024
@ghpbot-tari-project ghpbot-tari-project added the P-acks_required Process - Requires more ACKs or utACKs label Apr 15, 2024
Copy link

github-actions bot commented Apr 15, 2024

Test Results (CI)

    3 files    120 suites   39m 4s ⏱️
1 278 tests 1 278 ✅ 0 💤 0 ❌
3 826 runs  3 826 ✅ 0 💤 0 ❌

Results for commit 6235270.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 15, 2024

Test Results (Integration tests)

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 6235270.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Apr 15, 2024
# Conflicts:
#	applications/minotari_merge_mining_proxy/Cargo.toml
#	applications/minotari_merge_mining_proxy/src/run_merge_miner.rs
#	applications/minotari_node/Cargo.toml
#	applications/minotari_node/src/grpc/base_node_grpc_server.rs
@stringhandler stringhandler merged commit c5257ee into tari-project:feature-dan2 Apr 15, 2024
13 of 14 checks passed
@stringhandler stringhandler deleted the st-use-manifest-version branch April 15, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants