fix: hot for removing breaking change in wallet, new release for nexnet v1.0.0-rc.8 #6305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
the
P-acks_required
Test Results (CI) 3 files 120 suites 36m 22s ⏱️ Results for commit 129ad9c. |
Test Results (Integration tests) 2 files 11 suites 15m 26s ⏱️ For more details on these failures, see this check. Results for commit 129ad9c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed breaking change of wallet db type
Release new nextnet version
Motivation and Context
Release v1.0.0-rc.7 accidentally included an unmarked breaking change. This change is for future ledger support in with saving the wallet type as software or ledger in the wallet db. This is a breaking change. This forces a wallet to be software as ledger is currently in dev and not yet functioning.
How Has This Been Tested?
Manual