Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backup spend #6466

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Conversation

SWvheerden
Copy link
Collaborator

Description

Fixes backup spend to ensure correct keys are used, and correct functions are called

Motivation and Context

Functions should be correct in their usage and allow ledger/non ledger keys to be used

@SWvheerden SWvheerden requested a review from a team as a code owner August 13, 2024 09:24
Copy link

github-actions bot commented Aug 13, 2024

Test Results (CI)

    3 files    126 suites   38m 33s ⏱️
1 303 tests 1 303 ✅ 0 💤 0 ❌
3 901 runs  3 901 ✅ 0 💤 0 ❌

Results for commit 8a76910.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Aug 13, 2024
Copy link

github-actions bot commented Aug 13, 2024

Test Results (Integration tests)

 2 files   1 errors  9 suites   12m 7s ⏱️
19 tests 18 ✅ 0 💤 1 ❌
20 runs  19 ✅ 0 💤 1 ❌

For more details on these parsing errors and failures, see this check.

Results for commit 8a76910.

♻️ This comment has been updated with latest results.

hansieodendaal
hansieodendaal previously approved these changes Aug 13, 2024
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Just some clippy issues.

(Needs to be tested with system-level testing after a new pre-mine has been created)

@SWvheerden SWvheerden merged commit 0fa0ca4 into tari-project:development Aug 14, 2024
15 of 17 checks passed
@SWvheerden SWvheerden deleted the sw_fix_backup_spend branch August 15, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants