fix: lock version of hickory-client #6716
Conversation
Test Results (CI) 3 files 129 suites 38m 51s ⏱️ Results for commit 4cf1fee. ♻️ This comment has been updated with latest results. |
| "dns-over-rustls", | ||
| "dnssec-openssl", | ||
| ], optional = true } | ||
| hickory-proto = { version = "=0.25.0-alpha.2" } |
There was a problem hiding this comment.
why is this added in here?
There was a problem hiding this comment.
When I've locked hickory-client to 0.25.0-alpha.2 for some reason this hickory-proto still tried to use alpha 4 version of itself which broke the build so I added entry for this package with also locked version to 0.25.0-alpha.2
There was a problem hiding this comment.
you are adding a package thats not used by tari. You can see its complaining about it in machete
There was a problem hiding this comment.
This is needed because hickory pushed a new version that doesn't compile, so you have to pin it like this.
There was a problem hiding this comment.
please comment why its done there as well, I cant seem to add it via github review
Fix missing comments in #6716
[ Motivation ]
Solves issues in repositories:
universe=> https://github.com/tari-project/universetarigpuminer=> https://github.com/stringhandler/tarigpuminerFrom what I understand
hickory-clientwas implemented on version0.25.0-alpha.2. Since that time there was release for version0.25.0-alpha.3and0.25.0-alpha.4with breaking changes which require code adjustments. Because we didn't lock version to0.25.0-alpha.2here, in mentioned repositories during build when it comes to building tari_core => tari_p2p it tries to use versions higher then0.25.0-alpha.2which breaks the build. It also happens in this repository when you delete Cargo.lock file.To this moment we patched this in mentioned repositories by including these packages with locked versions in Cargo.toml but it cause other smaller problems