Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add libtor exiting logic #6782

Merged
merged 3 commits into from
Feb 5, 2025

review comments

b6e029b
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: add libtor exiting logic #6782

review comments
b6e029b
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Integration tests) failed Feb 5, 2025 in 0s

2 fail, 34 pass in 53m 53s

 2 files  ±0  11 suites  ±0   53m 53s ⏱️ - 2m 53s
36 tests ±0  34 ✅ +1  0 💤 ±0  2 ❌  - 1 
39 runs   - 1  35 ✅  - 1  0 💤 ±0  4 ❌ ±0 

Results for commit b6e029b. ± Comparison against earlier commit c57223f.

Annotations

Check warning on line 0 in /

See this annotation in the file changed.

@github-actions github-actions / Test Results (Integration tests)

1 out of 2 runs failed: Scenario: Simple reorg to stronger chain: tests/features/Reorgs.feature:8:3

artifacts/junit-cucumber/cucumber-output-junit.xml [took 2m 36s]
Raw output
Step panicked. Captured output: base node didn't synchronize successfully with height 10, current chain height 3
  Scenario: Simple reorg to stronger chain
   ✔  Given I have a seed node SEED_B
   ✔  When I have a base node B connected to seed SEED_B
   ✔  When I have wallet WB connected to base node B
   ✔  When I have mining node BM connected to base node B and wallet WB
   ✔  When mining node BM mines 3 blocks with min difficulty 1 and max difficulty 50
   ✔  Given I have a seed node SEED_C
   ✔  When I have a base node C connected to seed SEED_C
   ✔  When I have wallet WC connected to base node C
   ✔  When I have mining node CM connected to base node C and wallet WC
   ✔  When mining node CM mines 10 blocks with min difficulty 51 and max difficulty 9999999999
   ✔  Then node B is at height 3
   ✔  Then node C is at height 10
   ✔  When I have a base node SA connected to nodes B,C
   ✔  Then node SA is at height 10
   ✘  Then node B is at height 10
      Step failed:
      Defined: tests/features/Reorgs.feature:28:5
      Matched: integration_tests/tests/steps/node_steps.rs:218:1
      Step panicked. Captured output: base node didn't synchronize successfully with height 10, current chain height 3
      Client {
          base_nodes: {},
          blocks: {},
          miners: {
              "BM": MinerProcess {
                  name: "BM",
                  base_node_name: "B",
                  wallet_name: "WB",
                  mine_until_height: 100000,
                  stealth: false,
              },
              "CM": MinerProcess {
                  name: "CM",
                  base_node_name: "C",
                  wallet_name: "WC",
                  mine_until_height: 100000,
                  stealth: false,
              },
          },
          ffi_wallets: {},
          wallets: {},
          merge_mining_proxies: {},
          chat_clients: [],
          transactions: {},
          wallet_addresses: {},
          utxos: {},
          output_hash: None,
          pre_image: None,
          wallet_connected_to_base_node: {
              "WB": "B",
              "WC": "C",
          },
          seed_nodes: [
              "SEED_B",
              "SEED_C",
          ],
          wallet_tx_ids: {},
          errors: [],
          last_imported_tx_ids: [],
          last_merge_miner_response: Null,
      }

Check warning on line 0 in /

See this annotation in the file changed.

@github-actions github-actions / Test Results (Integration tests)

All 3 runs failed: Scenario: As a wallet send to a wallet connected to a different base node: tests/features/WalletTransfer.feature:9:3

artifacts/junit-cucumber/cucumber-output-junit.xml [took 9m 41s]
Raw output
Step panicked. Captured output: Wallet WALLET_B failed to have at least 5T, it ended with 0T
  Scenario: As a wallet send to a wallet connected to a different base node
   ✔  Given I have a seed node SEED_A
   ✔  When I have a seed node SEED_B
   ✔  When I have a base node NODE_A connected to all seed nodes
   ✔  When I have a base node NODE_B connected to all seed nodes
   ✔  When I have wallet WALLET_A with 10T connected to base node NODE_A
   ✔  When I have wallet WALLET_B connected to base node NODE_B
   ✔  When I wait 5 seconds
   ✔  When I transfer 5T from WALLET_A to WALLET_B
   ✔  When I mine 4 blocks on SEED_A
   ✔  Then wallet WALLET_A has 5T
   ✔  When I wait 5 seconds
   ✘  When wallet WALLET_B has 5T
      Step failed:
      Defined: tests/features/WalletTransfer.feature:21:5
      Matched: integration_tests/tests/steps/wallet_steps.rs:1537:1
      Step panicked. Captured output: Wallet WALLET_B failed to have at least 5T, it ended with 0T
      Client {
          base_nodes: {},
          blocks: {},
          miners: {
              "temp_miner": MinerProcess {
                  name: "temp_miner",
                  base_node_name: "NODE_A",
                  wallet_name: "WALLET_A",
                  mine_until_height: 100000,
                  stealth: false,
              },
          },
          ffi_wallets: {},
          wallets: {},
          merge_mining_proxies: {},
          chat_clients: [],
          transactions: {},
          wallet_addresses: {},
          utxos: {},
          output_hash: None,
          pre_image: None,
          wallet_connected_to_base_node: {
              "WALLET_A": "NODE_A",
              "WALLET_B": "NODE_B",
          },
          seed_nodes: [
              "SEED_A",
              "SEED_B",
          ],
          wallet_tx_ids: {
              "H4NyDBnabCLiYZHUhpoe8Jm6SdaTPzjejYqjCaqxMsTa6FhbjnCfiWa2eQMHSqnPPYL57ENWN7h1Q9Dvn9n5XEj8tdJ": [
                  9375832431517618500,
              ],
              "H48y32nXSaeMUcHnw5EjAYQmpZUZ5giXmgXZzyLNeKHUpLNEKGmgqZBFJhSf6TG5aUeNjxrjvMexjZ1SuR41qFQzoeD": [
                  9375832431517618500,
              ],
          },
          errors: [],
          last_imported_tx_ids: [],
          last_merge_miner_response: Null,
      }

Check notice on line 0 in .github

See this annotation in the file changed.

@github-actions github-actions / Test Results (Integration tests)

36 tests found

There are 36 tests, see "Raw output" for the full list of tests.
Raw output
Scenario: A message is propagated between clients via 3rd party: tests/features/ChatFFI.feature:7:3
Scenario: A message is propagated between side loaded chat and client via 3rd party: tests/features/ChatFFI.feature:105:3
Scenario: A message is sent directly between two FFI clients: tests/features/ChatFFI.feature:49:3
Scenario: A message receives a delivery receipt via FFI: tests/features/ChatFFI.feature:74:3
Scenario: A message receives a read receipt via FFI: tests/features/ChatFFI.feature:82:3
Scenario: A single message is fetched from FFI: tests/features/ChatFFI.feature:113:3
Scenario: As a client I want to receive a one-sided transaction: tests/features/WalletFFI.feature:212:5
Scenario: As a client I want to receive contact liveness events: tests/features/WalletFFI.feature:73:5
Scenario: As a client I want to retrieve a list of transactions I have made and received: tests/features/WalletFFI.feature:96:5
Scenario: As a client I want to retrieve the mnemonic word list for a given language: tests/features/WalletFFI.feature:24:5
Scenario: As a client I want to send a one-sided transaction: tests/features/WalletFFI.feature:175:5
Scenario: As a wallet I want to submit a transaction: tests/features/WalletQuery.feature:18:3
Scenario: As a wallet send to a wallet connected to a different base node: tests/features/WalletTransfer.feature:9:3
Scenario: Callback for delivery confirmation received: tests/features/ChatFFI.feature:22:3
Scenario: Callback for new message received: tests/features/ChatFFI.feature:14:3
Scenario: Callback for read confirmation received: tests/features/ChatFFI.feature:31:3
Scenario: Callback for status change is received: tests/features/ChatFFI.feature:41:3
Scenario: Chat shuts down without any errors: tests/features/ChatFFI.feature:59:3
Scenario: Clear out mempool: tests/features/Mempool.feature:46:3
Scenario: Create burn transaction: tests/features/WalletTransactions.feature:412:3
Scenario: Fetches all addresses from FFI conversations: tests/features/ChatFFI.feature:91:3
Scenario: Node rolls back reorg on invalid block: tests/features/Reorgs.feature:63:3
Scenario: Reply to message: tests/features/ChatFFI.feature:64:3
Scenario: Simple block sync: tests/features/Sync.feature:26:3
Scenario: Simple propagation: tests/features/Propagation.feature:26:3
Scenario: Simple reorg to stronger chain: tests/features/Reorgs.feature:8:3
Scenario: Simple reorg with burned output: tests/features/Reorgs.feature:33:3
Scenario: Sync burned output: tests/features/Sync.feature:34:3
Scenario: Transactions are propagated through a network: tests/features/Mempool.feature:8:3
Scenario: Verify UTXO and kernel MMR size in header: tests/features/BlockTemplate.feature:8:1
Scenario: Verify gprc can create block with more than 1 coinbase: tests/features/BlockTemplate.feature:14:5
Scenario: Wallet imports pre_mine UTXO: tests/features/WalletTransactions.feature:170:3
Scenario: Wallet recovery with connected base node staying online: tests/features/WalletRecovery.feature:8:5
Scenario: Wallet sending and receiving one-sided transactions: tests/features/WalletTransactions.feature:8:3
Scenario: When a new node joins the network, it receives all peers: tests/features/Sync.feature:77:3
Scenario: Zero-conf transactions: tests/features/Mempool.feature:124:3