Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade crossterm #6783

Merged

Conversation

hansieodendaal
Copy link
Contributor

Description

  • Upgraded crossterm to the latest version (0.28)
  • Fixed Windows compatibility issues for the console wallet

Closes #6211

Motivation and Context

crossterm needed updating - see #6211

How Has This Been Tested?

System-level testing on Windows and Linux (Ubuntu WSL)

What process can a PR reviewer use to test or verify this change?

System-level testing
Code review

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

- Upgraded crossterm to the latest version (0.28)
- Fixed Windows compatibility issues for the console wallet
Copy link

github-actions bot commented Feb 4, 2025

Test Results (CI)

    3 files    129 suites   37m 57s ⏱️
1 360 tests 1 360 ✅ 0 💤 0 ❌
4 078 runs  4 078 ✅ 0 💤 0 ❌

Results for commit dde0cbf.

Copy link

github-actions bot commented Feb 4, 2025

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   31m 1s ⏱️ + 31m 1s
36 tests +36  35 ✅ +35  0 💤 ±0  1 ❌ +1 
37 runs  +37  36 ✅ +36  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit dde0cbf. ± Comparison against base commit f5365ca.

@SWvheerden SWvheerden merged commit 3ad35af into tari-project:development Feb 5, 2025
16 of 17 checks passed
@hansieodendaal hansieodendaal deleted the ho_upgrade_crossterm branch February 5, 2025 15:48
hansieodendaal added a commit to hansieodendaal/tari that referenced this pull request Feb 5, 2025
- Verified wallet recovery does not always start scanning from the genesis block instead of from
a bit before the closest wallet birthday block.
- Fixed a Windows build error introduced by tari-project#6783.
@hansieodendaal hansieodendaal mentioned this pull request Feb 5, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix cross term win compatibility upgrade to 0.27
2 participants