Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: add RegExp.escape #3382

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Normative: add RegExp.escape #3382

merged 1 commit into from
Feb 27, 2025

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Jul 30, 2024

@ljharb ljharb added normative change Affects behavior required to correctly evaluate some ECMAScript source text pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. has test262 tests proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. labels Jul 30, 2024
@ljharb ljharb requested a review from a team July 30, 2024 18:16
@ljharb ljharb mentioned this pull request Jul 30, 2024
Closed
33 tasks
jmdyck
jmdyck requested changes Aug 28, 2024
View reviewed changes
ljharb added a commit to ljharb/ecma262 that referenced this pull request Aug 28, 2024
@ljharb
Normative: add RegExp.escape (tc39#3382)
1551bbf
@ljharb ljharb requested a review from jmdyck August 28, 2024 20:29
ljharb added a commit to tc39/proposal-regex-escaping that referenced this pull request Aug 28, 2024
@ljharb
[spec] feedback from tc39/ecma262#3382 (review)
44f4fb9
@michaelficarra michaelficarra mentioned this pull request Aug 28, 2024
Open
ljharb added a commit to ljharb/ecma262 that referenced this pull request Aug 28, 2024
@ljharb
Normative: add RegExp.escape (tc39#3382)
14df80b
@michaelficarra
Copy link
Member

deleted .github?! 😰

ljharb added a commit to ljharb/ecma262 that referenced this pull request Aug 28, 2024
@ljharb
Normative: add RegExp.escape (tc39#3382)
1867fff
@ljharb
Copy link
Member Author

ljharb commented Aug 28, 2024

fixed; i have no idea how that happened

ljharb added a commit to ljharb/ecma262 that referenced this pull request Aug 28, 2024
@ljharb
Normative: add RegExp.escape (tc39#3382)
6110ce5
jmdyck
jmdyck requested changes Aug 29, 2024
View reviewed changes
ljharb added a commit to ljharb/ecma262 that referenced this pull request Aug 29, 2024
@ljharb
Normative: add RegExp.escape (tc39#3382)
270847a
@jmdyck
Copy link
Collaborator

jmdyck commented Aug 29, 2024

Passes my checks now.

ljharb added a commit to ljharb/ecma262 that referenced this pull request Oct 21, 2024
@ljharb
Normative: add RegExp.escape (tc39#3382)
d8495c3
jmdyck
jmdyck reviewed Oct 22, 2024
View reviewed changes
ljharb added a commit to ljharb/ecma262 that referenced this pull request Oct 22, 2024
@ljharb
Normative: add RegExp.escape (tc39#3382)
acd63af
@ljharb ljharb added has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. and removed pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. labels Feb 18, 2025
michaelficarra
michaelficarra reviewed Feb 26, 2025
View reviewed changes
michaelficarra
michaelficarra reviewed Feb 26, 2025
View reviewed changes
ljharb added a commit to ljharb/ecma262 that referenced this pull request Feb 26, 2025
@ljharb
Normative: add RegExp.escape (tc39#3382)
23cdfae
michaelficarra
michaelficarra approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. While not necessary, the spelling warnings suggest that maybe we shouldn't try to shorten codepoint to c or cp if we're not doing it elsewhere.

@michaelficarra michaelficarra added the editor call to be discussed in the next editor call label Feb 26, 2025
@michaelficarra
Copy link
Member

It looks like cp at least is a common abbreviation but the spell checker isn't picking it up, probably because it's not 3+ letters long. We should probably hard-code some short pre-existing abbreviations like this one in the spell checker.

bakkot
bakkot reviewed Feb 26, 2025
View reviewed changes
@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Feb 26, 2025
@michaelficarra michaelficarra removed the editor call to be discussed in the next editor call label Feb 26, 2025
@ljharb ljharb merged commit e2da759 into tc39:main Feb 27, 2025
7 checks passed
@ljharb ljharb deleted the escape branch February 27, 2025 06:25
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Feb 28, 2025
@jmdyck
Editorial: Change remaining _c_ to _cp_ in EncodeForRegExpEscape
c7fb698 
(Quick fix re PR tc39#3382.)
@jmdyck jmdyck mentioned this pull request Feb 28, 2025
Merged
ljharb pushed a commit to jmdyck/ecma262 that referenced this pull request Feb 28, 2025
@jmdyck @ljharb
Editorial: Change remaining _c_ to _cp_ in EncodeForRegExpEscape (t…
d06f3a2 
…c39#3546)

(Quick fix re PR tc39#3382)
@bakkot bakkot mentioned this pull request Feb 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakkot bakkot bakkot approved these changes

@jmdyck jmdyck jmdyck approved these changes

@syg syg syg approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

Assignees
No one assigned
Labels
has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. has test262 tests normative change Affects behavior required to correctly evaluate some ECMAScript source text proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ljharb @michaelficarra @jmdyck @syg @bakkot