Polish docker/podman images #3494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
requested review from
psss,
lukaszachy,
thrix,
janhavlin and
martinhoyer
as code owners
happz
force-pushed
the
containers-refurbished
branch
from
088c76c to
f7c6de7
Compare
After the question about indentation in containerfiles has been raised several times, it's time to do something about it. And can't stop with just one issue, so touching several parts of the image building process: * adding a linter to pre-commit for containerimages, and fixing issues reported by it. * using heredoc + `RUN` instead of often weirdly aligned multiline `RUN`. * renamed `make` targets: `images`, `images/test`, `images/test/bases`, `clean`, `clean/images`, `clean/images/test` * renamed images as well, to have a nice namespace for container images and regular container images, not the test ones, etc.: `tmt/container/tmt-all`, `tmt/container/tmt`, `tmt/container/test/alpine`, ... * simplified coe building images in `Makefile` to use same path for both test and tmt images.
happz
force-pushed
the
containers-refurbished
branch
from
f7c6de7 to
83d7a00
Compare
psss
requested changes
Feb 5, 2025
psss
approved these changes
Feb 6, 2025
therazix
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the question about indentation in containerfiles has been raised several times, it's time to do something about it. And can't stop with just one issue, so touching several parts of the image building process:
RUNinstead of often weirdly aligned multilineRUN.maketargets:images,images/test,images/test/bases,clean,clean/images,clean/images/testtmt/container/tmt-all,tmt/container/tmt,tmt/container/test/alpine, ...Makefileto use same path for both test and tmt images.Pull Request Checklist