update to huffman v2 - removes tree initialization nearly completely #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
old (Unpack): new - not visible at all: It was a quick benchmark, nothing scientific or sophisticated. Sampling times differ by a factor of 5x. 10 vs 2 secs |
protocol7/packet.go
Outdated
| @@ -336,8 +336,7 @@ func (packet *Packet) Unpack(data []byte) (err error) { | |||
| if packet.Header.Flags.Compression { | |||
| // TODO: try avoiding repeated initialization of the huffman tree structure | |||
| // move this into the Packet struct or even further up | |||
There was a problem hiding this comment.
this comment can be removed now
|
yay faster is really cool! But now we are forced to rebuild the tree for every packet and can not cache it? |
|
it was previously rebuild every time. Now it's build once upon application startup as a global dictionary variable in the huffman v2 package. And reused for lookups. |
|
Okay nice. I think we had that discussion in the huffman repo already 🙈 |
|
Nice thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.