Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for ICS/JB qualizer bug #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Quick fix for ICS/JB qualizer bug #32

wants to merge 1 commit into from

Conversation

Elettronik
Copy link

This fix FC on ICS devices, tested on SGS I900 CM9, the same should work on JB too

@MarcinGil
Copy link
Collaborator

Hmm.. I'm not a fan of catching and ignoring exceptions like that. Were you able to find out what is the reason this exception is thrown out?

@Elettronik
Copy link
Author

I find some reference on an upstream bug on this classes, which seem it won't fixed.

http://code.google.com/p/cyanogenmod/issues/detail?id=4327
http://code.google.com/p/android/issues/detail?id=33669
http://stackoverflow.com/questions/11193239/using-audiosessionid-value-to-instantiate-audiofx-class

I know it's a bad program style to catch and ignore exception, but seem working on ICS device. maybe a better solution could be logging error, or checking api level you are working on, and then using right classes,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants