[WIP] Task/align with group uniqueness doc

CHANGES_NEXT_RELEASE

@@ -1 +1,2 @@
-- Upgrade express de from 4.19.2 to 4.20.0
+- Fix: align group index to align with group uniqueness (iotagent-node-lib#1633,#1589)
+- Upgrade express de from 4.19.2 to 4.20.0

doc/api.md

@@ -169,6 +169,9 @@ Group uniqueness is defined by the combination of: service, subservice, resource
 Device uniqueness is defined by the combination of: service, subservice, device_id and apikey. Note that several devices
 with the same device_id are allowed in the same service and subservice as long as their apikeys are different.
 
+Note that existent deployments based on previous versions of iotagent-node-lib could use more restrictive unique indexes
+in mongodb (specially for groups model) still not updated.
+
 ## Special measures and attributes names
 
 In case of arriving measures with name `id` or `type`, they are automatically transformed to `measure_id` and

lib/model/Group.js

@@ -69,7 +69,7 @@ const Group = new Schema({
 });
 
 function load(db) {
-    Group.index({ apikey: 1, resource: 1 }, { unique: true });
+    Group.index({ apikey: 1, resource: 1, service: 1, subservice: 1 }, { unique: true });
     module.exports.model = db.model('Group', Group);
     module.exports.internalSchema = Group;
 }

lib/services/groups/groupRegistryMongoDB.js

@@ -93,21 +93,25 @@ function createGroup(group, callback) {
 
     logger.debug(
         context,
-        'Storing device group with id [%s], type [%s], apikey [%s] and resource [%s]',
+        'Storing device group with id [%s], type [%s], apikey [%s], resource [%s], service [%s] and subservice [%s]',
         groupObj._id,
         groupObj.type,
         groupObj.apikey,
-        groupObj.resource
+        groupObj.resource,
+        groupObj.service,
+        groupObj.subservice
     );
 
     groupObj.save(function saveHandler(error, groupDAO) {
         if (error) {
             if (error.code === 11000) {
                 logger.debug(
                     context,
-                    'Duplicate group entry with resource [%s] and apiKey [%s]',
+                    'Duplicate group entry with resource [%s], apiKey [%s], servuce [%s] and subservice %[s]',
                     group.resource,
-                    group.apikey
+                    group.apikey,
+                    group.service,
+                    group.subservice
                 );
 
                 callback(new errors.DuplicateGroup(group));