replace current_since_time with routing_update_time

temporalio · Jan 28, 2025 · 1183dad · 1183dad
1 parent 80a6fbd
commit 1183dad
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 28 deletions.
diff --git a/openapi/openapiv2.json b/openapi/openapiv2.json
@@ -13359,15 +13359,19 @@
           "type": "string",
           "format": "date-time"
         },
-        "currentSinceTime": {
+        "routingUpdateTime": {
           "type": "string",
           "format": "date-time",
-          "description": "\nNil if not current."
+          "description": "Last time `is_current` or `ramp_percentage` of this version changed."
         },
-        "rampingSinceTime": {
-          "type": "string",
-          "format": "date-time",
-          "description": "\nNil if not ramping."
+        "isCurrent": {
+          "type": "boolean",
+          "description": "If this version is the current version of its deployment."
+        },
+        "rampPercentage": {
+          "type": "number",
+          "format": "float",
+          "description": "Range: [0, 100]. Must be zero if is_current is true. Must be non-zero if version is ramping."
         },
         "taskQueueInfos": {
           "type": "array",

diff --git a/openapi/openapiv3.yaml b/openapi/openapiv3.yaml
@@ -10759,20 +10759,17 @@ components:
         createTime:
           type: string
           format: date-time
-        currentSinceTime:
+        routingUpdateTime:
           type: string
-          description: |-
-            (-- api-linter: core::0140::prepositions=disabled
-                 aip.dev/not-precedent: 'Since' captures the field semantics despite being a preposition. --)
-             Nil if not current.
-          format: date-time
-        rampingSinceTime:
-          type: string
-          description: |-
-            (-- api-linter: core::0140::prepositions=disabled
-                 aip.dev/not-precedent: 'Since' captures the field semantics despite being a preposition. --)
-             Nil if not ramping.
+          description: Last time `is_current` or `ramp_percentage` of this version changed.
           format: date-time
+        isCurrent:
+          type: boolean
+          description: If this version is the current version of its deployment.
+        rampPercentage:
+          type: number
+          description: 'Range: [0, 100]. Must be zero if is_current is true. Must be non-zero if version is ramping.'
+          format: float
         taskQueueInfos:
           type: array
           items:

diff --git a/temporal/api/deployment/v1/message.proto b/temporal/api/deployment/v1/message.proto
@@ -132,18 +132,17 @@ message WorkerDeploymentVersionInfo {
 
     google.protobuf.Timestamp create_time = 3;
 
-    // (-- api-linter: core::0140::prepositions=disabled
-    //     aip.dev/not-precedent: 'Since' captures the field semantics despite being a preposition. --)
-    // Nil if not current.
-    google.protobuf.Timestamp current_since_time = 4;
+    // Last time `is_current` or `ramp_percentage` of this version changed.
+    google.protobuf.Timestamp routing_update_time = 4;
 
-    // (-- api-linter: core::0140::prepositions=disabled
-    //     aip.dev/not-precedent: 'Since' captures the field semantics despite being a preposition. --)
-    // Nil if not ramping.
-    google.protobuf.Timestamp ramping_since_time = 5;
+    // If this version is the current version of its deployment.
+    bool is_current = 5;
+
+    // Range: [0, 100]. Must be zero if is_current is true. Must be non-zero if version is ramping.
+    float ramp_percentage = 6;
 
     // All the Task Queues that have ever polled from this Deployment version.
-    repeated DeploymentVersionTaskQueueInfo task_queue_infos = 6;
+    repeated DeploymentVersionTaskQueueInfo task_queue_infos = 7;
 
     message DeploymentVersionTaskQueueInfo {
         string name = 1;
@@ -163,7 +162,7 @@ message WorkerDeploymentVersionInfo {
     //   This means if the Version is "drained" but new workflows are sent to it via
     //   Pinned Versioning Override, the status does not account for those Pinned-override
     //   executions and remains "drained".
-    VersionDrainageInfo drainage_info = 7;
+    VersionDrainageInfo drainage_info = 8;
 
     // TODO (Shivam): + Poller_status + WorkerDeploymentVersionMetadata
 }