-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add root workflow execution to WorkflowExecutionStartedEventAttributes #366
Conversation
Could you add some documentation to the code explaining what the fields are and how they should be used? (Also the PR itself doesn't have any explanation, but that could come from the code comments in a proto API PR). |
4a9da7f
to
b9f7668
Compare
b9f7668
to
cfa417d
Compare
cfb08ad
to
921a7ef
Compare
921a7ef
to
f5b4c11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving from API POV, but would like to see reset behavior on this field documented (i.e. that it doesn't change across reset if that's the behavior)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for explaining! I added an optional suggestion to make it explicit that if A--CAN-->B
then parent(B) = parent(A)
.
6905dcc
to
1032e59
Compare
The implementation in the Server is here: temporalio/temporal#5520 |
1032e59
to
9e8a918
Compare
9e8a918
to
c431447
Compare
What changed?
Add fields for root workflow execution.
The root workflow execution is defined as follows:
Examples:
Why?
Breaking changes