Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reset] Define child handling policies #498

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −0
Draft

[Reset] Define child handling policies #498

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
523e46c
[Reset] Define child handling policies
gow Nov 26, 2024
812e05c
Fix lint
gow Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions temporal/api/enums/v1/workflow.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,13 @@ enum ParentClosePolicy {
PARENT_CLOSE_POLICY_REQUEST_CANCEL = 3;
}

// ResetChildPolicy specifies the policy to apply to child workflows when a parent is reset.
enum ResetChildPolicy {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this enum referenced/used in the API?

Copy link
Contributor Author

@gow gow Dec 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the corresponding change yet. The intent is to use it in ResetWorkflowExecutionRequest .

api/temporal/api/workflowservice/v1/request_response.proto

Line 763 in bae790a

message ResetWorkflowExecutionRequest {

For now I'm holding off on this. Will update this PR when I get to working on the API.

RESET_CHILD_POLICY_UNSPECIFIED = 0;
// Reconnects to the currently running child.
RESET_CHILD_POLICY_RECONNECT = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we initially only support terminateAndRerun for children initiated after the reset point?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We don't need it immediately. But I need a way to know if the current run is a result of a reset. So wanted to add this.
But on second thought I think we should add an explicit flag in the new run to mark it as a reset-run. Doing that in this PR - temporalio/temporal#6916

}

enum ContinueAsNewInitiator {
CONTINUE_AS_NEW_INITIATOR_UNSPECIFIED = 0;
// The workflow itself requested to continue as new
Expand Down
Loading