Add HandlerErrorRetryBehavior #551
Merged
+74
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
force-pushed
the
nexus-error-tweaks
branch
from
03f2e7b to
d9c0992
Compare
Quinn-With-Two-Ns
approved these changes
Feb 6, 2025
cretz
reviewed
Feb 6, 2025
temporal/api/nexus/v1/message.proto
Outdated
| // HandlerErrorRetryBehavior allows handlers to explicity set the retry behavior of a HandlerError. If not specified, | ||
| // retry behavior is determined from the error type. For example internal errors are not retryable by default unless | ||
| // specified otherwise. | ||
| enum HandlerErrorRetryBehavior { |
There was a problem hiding this comment.
Should this be in enums like all other enums in this project?
There was a problem hiding this comment.
Yeah, you're right, I checked, all other enums are there. I don't love spreading related definitions out like that but I understand the argument for consistency.
pdoerner
approved these changes
Feb 6, 2025
cretz
approved these changes
Feb 6, 2025
|
Yes, there is a corresponding server and Go SDK PR (Java is waiting on this too). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.