EDU-3846: Nexus circuit breaker docs #3305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
approved these changes
Jan 27, 2025
rodrigozhou
reviewed
Jan 27, 2025
rodrigozhou
approved these changes
Jan 27, 2025
|
Yes, it's all reviewed on the technical side, @fairlydurable. There's a couple of suggestions that I'd leave up to @prasek's consideration. |
fairlydurable
changed the title
fairlydurable
added
cross-team
Signed-off-by: Phil Prasek <prasek@gmail.com>
Signed-off-by: Phil Prasek <prasek@gmail.com>
Co-authored-by: Rodrigo Zhou <2068124+rodrigozhou@users.noreply.github.com>
Signed-off-by: Phil Prasek <prasek@gmail.com>
|
Hi @fairlydurable -- all feedback has been resolved and it's ready for final docs review, thanks! |
fairlydurable
added a commit
that referenced
this pull request
Jan 29, 2025
- Added intro motivating and defining what circuit breaking is - Added explanatory image - Fixed typos - Tightened grammar - Incorporated changes from original PR #3305
fairlydurable
added a commit
that referenced
this pull request
Jan 31, 2025
- This is technically reviewed - The original PR wasn't able to be edited, so this is a duplicate with review edits applied. - Merging * EDU-3846: Updates nexus operations to add circuit breaking - Added intro motivating and defining what circuit breaking is - Added explanatory image - Fixed typos - Tightened grammar - Incorporated changes from original PR #3305 * Update docs/encyclopedia/nexus-operations.mdx * Update docs/encyclopedia/nexus-operations.mdx
|
Merged under separate PR. Closing. Ticket is complete and published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?