Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to custom docker image #37

Merged
merged 1 commit into from
Apr 3, 2024
Merged

switch to custom docker image #37

merged 1 commit into from
Apr 3, 2024

Conversation

axfelix
Copy link
Contributor

@axfelix axfelix commented Apr 3, 2024

No description provided.

@tomwheeler tomwheeler self-requested a review April 3, 2024 20:05
Copy link
Contributor

@tomwheeler tomwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I inspected the files and also tested a GitPod workspace created from the PR branch. It worked as expected (caveat: I didn't test the workspace timeout and resume, in the interest of time, but would expect that would work as it did in the Temporal 101 with Go course upon which this configuration is based).

@axfelix axfelix merged commit 09be383 into main Apr 3, 2024
2 checks passed
@axfelix axfelix deleted the custom-docker-image branch April 3, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants