Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing name from patchversion to versionworkflow #11

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

MasonEgger
Copy link
Collaborator

No description provided.

@tomwheeler tomwheeler self-requested a review March 27, 2024 22:20
Copy link
Contributor

@tomwheeler tomwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the fix by checking out the branch for this PR and following these three steps:

  1. Run find . -name '*patch*' (this found three directories in the source tree when run on the main branch, but found zero on the patch-fix branch)
  2. Run mvn clean package from the exercises/version-workflow/practice directory (this completed successfully)
  3. Run mvn clean package from the exercises/version-workflow/solution directory (this completed successfully)

@tomwheeler tomwheeler merged commit d6fd9f8 into main Mar 27, 2024
2 checks passed
@tomwheeler tomwheeler deleted the patch-fix branch March 27, 2024 22:25
@tomwheeler
Copy link
Contributor

After merging the fix, I launched a new GitPod workspace (i.e., which now includes the fix on main) and repeated the three verifications described above. Results were the same, so this is successfully deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants