Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Workflow Update to Samples #99

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Adds Workflow Update to Samples #99

merged 3 commits into from
Dec 14, 2023

Conversation

rachfop
Copy link
Contributor

@rachfop rachfop commented Dec 12, 2023

What was changed

Adds the Workflow Update to the sample's repo.

Why?

Because users will want to see how to use the new Update feature with Python.
Gracefully shut down the worker too.

Checklist

  1. Closes

  2. How was this tested:

You need the Temporal Python 1.4 or above.
Only works on the local dev server with the config setup.

  1. Any docs updates needed?

Once this gets approved - I'll add something similar to the docs (and incorporate any additional feedback).

README.md Outdated Show resolved Hide resolved
workflow_update/starter.py Outdated Show resolved Hide resolved
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@cretz
Copy link
Member

cretz commented Dec 13, 2023

Looks like you may need to do a poe format. Also, hello/hello_update.py may be a better name than hello/hello_workflow_update.py to match signals, but this is fine too.

@rachfop rachfop merged commit c6cf076 into main Dec 14, 2023
8 checks passed
@rachfop rachfop deleted the workflow-update-sample branch December 14, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants