Skip to content

Commit

Permalink
Update README.md to remove note about DI issue (#152)
Browse files Browse the repository at this point in the history
  • Loading branch information
jakejscott authored Nov 8, 2023
1 parent 5b10051 commit abab4b2
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -268,12 +268,6 @@ synchronous method which creates a client that does not attempt to connect until
be helpful for dependency injection but beware that deferring connection until later can make it hard to see issues with
connection parameters as early as may be expected. However, connection must be made before a worker is created with it.

Note, there is a [known issue](https://github.com/temporalio/sdk-dotnet/issues/44) where creating the connected client
outside of the dependency injection container may cause it to not be usable via dependency injection because it was not
created in the container. Users should use lazy dependency injection abouve, however if the client must be created and
connected externally and non-lazily, the current suggestion is to put the connect `Task` as a singleton and resolve it
for each use similar to how other async DI utilities are used.

#### Data Conversion

Data converters are used to convert raw Temporal payloads to/from actual .NET types. A custom data converter can be set
Expand Down

0 comments on commit abab4b2

Please sign in to comment.