Run cloud tests in series to avoid wfID conflict #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Nov 30, 2023
If we see this failure any more I'll do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run cloud tests in series to avoid workflow ID conflict. When running parallel integration tests against the same cloud namespace it is possible if the same test runs at the same time the workflow IDs will conflict causing test failure.
example:
https://github.com/temporalio/sdk-go/actions/runs/7049993619/job/19189705118
Note: this isn't a perfect, the only way to properly fix is to run in separate namespaces or modify all the tests to add a UUID to every workflow and child workflow ID.