Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small docs/rendering fixes #1769

Merged
merged 2 commits into from
Jan 10, 2025
Merged

small docs/rendering fixes #1769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a048398
docs fixes
GSmithApps Jan 9, 2025
b3a487f
docs: fix list
GSmithApps Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/internal_task_pollers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,10 @@ func (bp *basePoller) stopping() bool {
}
}

// doPoll runs the given pollFunc in a separate go routine. Returns when either of the conditions are met:
// - poll succeeds, poll fails or worker is stopping
// doPoll runs the given pollFunc in a separate go routine. Returns when any of the conditions are met:
// - poll succeeds
GSmithApps marked this conversation as resolved.
Show resolved Hide resolved
// - poll fails
// - worker is stopping
func (bp *basePoller) doPoll(pollFunc func(ctx context.Context) (taskForWorker, error)) (taskForWorker, error) {
if bp.stopping() {
return nil, errStop
Expand Down
4 changes: 2 additions & 2 deletions workflow/doc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ the sole parameter it receives as part of its initialization as a parameter to t

func SimpleWorkflow(ctx workflow.Context, value string) error {
ao := workflow.ActivityOptions{
TaskQueue: "sampleTaskQueue",
TaskQueue: "sampleTaskQueue",
ScheduleToCloseTimeout: time.Second * 60,
ScheduleToStartTimeout: time.Second * 60,
StartToCloseTimeout: time.Second * 60,
Expand Down Expand Up @@ -149,7 +149,7 @@ The primary responsibility of the workflow implementation is to schedule activit
straightforward way to do that is via the library method [workflow.ExecuteActivity]:

ao := workflow.ActivityOptions{
TaskQueue: "sampleTaskQueue",
TaskQueue: "sampleTaskQueue",
ScheduleToCloseTimeout: time.Second * 60,
ScheduleToStartTimeout: time.Second * 60,
StartToCloseTimeout: time.Second * 60,
Expand Down
Loading