Add test; fix psalm

temporalio · Apr 9, 2024 · b575ab3 · b575ab3
1 parent 2c4bf07
commit b575ab3
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/src/Internal/Client/WorkflowStub.php b/src/Internal/Client/WorkflowStub.php
@@ -513,6 +513,7 @@ function (DescribeInput $input): WorkflowExecutionDescription {
                 $response = $this->serviceClient->DescribeWorkflowExecution($request);
                 $mapper = new WorkflowExecutionInfoMapper($this->converter);
 
+                /** @psalm-suppress PossiblyNullArgument */
                 return new WorkflowExecutionDescription(
                     info: $mapper->fromMessage($response->getWorkflowExecutionInfo()),
                 );

diff --git a/tests/Functional/Client/UntypedWorkflowStubTestCase.php b/tests/Functional/Client/UntypedWorkflowStubTestCase.php
@@ -19,6 +19,7 @@
 use Temporal\Exception\IllegalStateException;
 use Temporal\Exception\InvalidArgumentException;
 use Temporal\Tests\Unit\Declaration\Fixture\WorkflowWithoutHandler;
+use Temporal\Workflow\WorkflowExecutionStatus;
 
 /**
  * @group client
@@ -212,6 +213,31 @@ public function testTerminated()
         }
     }
 
+    public function testDescribe(): void
+    {
+        $client = $this->createClient();
+        $simple = $client->newUntypedWorkflowStub('SimpleSignalledWorkflowWithSleep');
+
+        $e = $client->start($simple, -1);
+
+        $stubDescription = $simple->describe();
+        $runDescription = $e->describe();
+
+        self::assertEquals($stubDescription, $runDescription);
+        self::assertSame(WorkflowExecutionStatus::Running, $runDescription->info->status);
+
+        $simple->terminate('user triggered');
+        // Wait a little bit for the workflow to terminate
+        \usleep(1000);
+
+        $stubDescription = $simple->describe();
+        $runDescription = $e->describe();
+
+        // After termination
+        self::assertEquals($stubDescription, $runDescription);
+        self::assertSame(WorkflowExecutionStatus::Terminated, $runDescription->info->status);
+    }
+
     public function testSignalRunningWorkflowWithInheritedSignal()
     {
         $client = $this->createClient();