Skip to content

Commit

Permalink
Fix psalm issues
Browse files Browse the repository at this point in the history
  • Loading branch information
roxblnfk committed Feb 11, 2025
1 parent f0c1ff4 commit db804e0
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 85 deletions.
86 changes: 2 additions & 84 deletions psalm-baseline.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="6.2.0@814dfde37b43a1fe6d9b0996e08b19661af53bc5">
<files psalm-version="6.4.1@09a200c15910905ddc49e5edd37b73f9c78f7580">
<file src="src/Activity.php">
<ImplicitToStringCast>
<code><![CDATA[$type]]></code>
Expand Down Expand Up @@ -984,89 +984,11 @@
<code><![CDATA[PromiseInterface]]></code>
</TooManyTemplateParams>
</file>
<file src="src/Internal/Transport/Request/Cancel.php">
<MissingImmutableAnnotation>
<code><![CDATA[Cancel]]></code>
</MissingImmutableAnnotation>
</file>
<file src="src/Internal/Transport/Request/CancelExternalWorkflow.php">
<MissingImmutableAnnotation>
<code><![CDATA[CancelExternalWorkflow]]></code>
</MissingImmutableAnnotation>
</file>
<file src="src/Internal/Transport/Request/CompleteWorkflow.php">
<MissingImmutableAnnotation>
<code><![CDATA[CompleteWorkflow]]></code>
</MissingImmutableAnnotation>
</file>
<file src="src/Internal/Transport/Request/ContinueAsNew.php">
<MissingImmutableAnnotation>
<code><![CDATA[ContinueAsNew]]></code>
</MissingImmutableAnnotation>
</file>
<file src="src/Internal/Transport/Request/ExecuteActivity.php">
<MissingImmutableAnnotation>
<code><![CDATA[ExecuteActivity]]></code>
</MissingImmutableAnnotation>
</file>
<file src="src/Internal/Transport/Request/ExecuteChildWorkflow.php">
<MissingImmutableAnnotation>
<code><![CDATA[ExecuteChildWorkflow]]></code>
</MissingImmutableAnnotation>
</file>
<file src="src/Internal/Transport/Request/ExecuteLocalActivity.php">
<MissingImmutableAnnotation>
<code><![CDATA[ExecuteLocalActivity]]></code>
</MissingImmutableAnnotation>
</file>
<file src="src/Internal/Transport/Request/GetChildWorkflowExecution.php">
<MissingImmutableAnnotation>
<code><![CDATA[GetChildWorkflowExecution]]></code>
</MissingImmutableAnnotation>
</file>
<file src="src/Internal/Transport/Request/GetVersion.php">
<MissingImmutableAnnotation>
<code><![CDATA[GetVersion]]></code>
</MissingImmutableAnnotation>
</file>
<file src="src/Internal/Transport/Request/NewTimer.php">
<MissingImmutableAnnotation>
<code><![CDATA[NewTimer]]></code>
</MissingImmutableAnnotation>
<PossiblyNullPropertyFetch>
<code><![CDATA[CarbonInterval::make($interval)->totalMilliseconds]]></code>
</PossiblyNullPropertyFetch>
</file>
<file src="src/Internal/Transport/Request/Panic.php">
<MissingImmutableAnnotation>
<code><![CDATA[Panic]]></code>
</MissingImmutableAnnotation>
</file>
<file src="src/Internal/Transport/Request/SideEffect.php">
<MissingImmutableAnnotation>
<code><![CDATA[SideEffect]]></code>
</MissingImmutableAnnotation>
</file>
<file src="src/Internal/Transport/Request/SignalExternalWorkflow.php">
<MissingImmutableAnnotation>
<code><![CDATA[SignalExternalWorkflow]]></code>
</MissingImmutableAnnotation>
</file>
<file src="src/Internal/Transport/Request/UndefinedResponse.php">
<MissingImmutableAnnotation>
<code><![CDATA[UndefinedResponse]]></code>
</MissingImmutableAnnotation>
</file>
<file src="src/Internal/Transport/Request/UpsertSearchAttributes.php">
<MissingImmutableAnnotation>
<code><![CDATA[UpsertSearchAttributes]]></code>
</MissingImmutableAnnotation>
</file>
<file src="src/Internal/Transport/Request/UpsertTypedSearchAttributes.php">
<MissingImmutableAnnotation>
<code><![CDATA[UpsertTypedSearchAttributes]]></code>
</MissingImmutableAnnotation>
</file>
<file src="src/Internal/Transport/Router/CancelWorkflow.php">
<DocblockTypeContradiction>
<code><![CDATA[$process === null]]></code>
Expand Down Expand Up @@ -1127,6 +1049,7 @@
<file src="src/Internal/Transport/Router/StartWorkflow.php">
<PossiblyFalseArgument>
<code><![CDATA[\json_encode($param)]]></code>
<code><![CDATA[\json_encode($param)]]></code>
</PossiblyFalseArgument>
<UnnecessaryVarAnnotation>
<code><![CDATA[Input]]></code>
Expand Down Expand Up @@ -1427,11 +1350,6 @@
<code><![CDATA[$this->failure]]></code>
</NullableReturnStatement>
</file>
<file src="src/Worker/Transport/Command/Client/Request.php">
<MissingImmutableAnnotation>
<code><![CDATA[Request]]></code>
</MissingImmutableAnnotation>
</file>
<file src="src/Worker/Transport/Command/Client/SuccessClientResponse.php">
<InvalidNullableReturnType>
<code><![CDATA[ValuesInterface]]></code>
Expand Down
3 changes: 3 additions & 0 deletions src/Worker/Transport/Command/Common/RequestTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ public function getHeader(): Header
return $this->header;
}

/**
* @psalm-external-mutation-free
*/
public function withHeader(HeaderInterface $header): self
{
$clone = clone $this;
Expand Down
2 changes: 1 addition & 1 deletion src/Workflow.php
Original file line number Diff line number Diff line change
Expand Up @@ -936,7 +936,7 @@ public static function allHandlersFinished(): bool
* ]
* ```
*
* @param array<string, mixed> $values
* @param array<non-empty-string, mixed> $values
*
* @since SDK 2.13.0
* @since RoadRunner 2024.3.3
Expand Down

0 comments on commit db804e0

Please sign in to comment.