Drop Python 3.7 support, ensure 3.12 support, update dependencies, and implement asyncio.timeout #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
force-pushed
the
drop-3.7
branch
15 times, most recently
from
3a3bf7e to
f1cdb33
Compare
cretz
changed the title
Sushisource
reviewed
Nov 14, 2023
Comment on lines
+1781
to
+1782
| # to only add to loop.time() and not an actual fixed point. Due to the | ||
| # fact that loop.time() is at a nanosecond level which floats can't |
There was a problem hiding this comment.
I think something like workflow.time() would be more obvious for users. Loop time seems like a bit on an unintuitive concept.
There was a problem hiding this comment.
That already exists. I just use loop.time() in this comment and in some other places when discussing this because that's how asyncio refers to it in their samples.
There was a problem hiding this comment.
OK, cool, I think the README should reference that then rather than loop
Sushisource
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
asyncio.wait_forsince the innards of that method changed from relative time to absolute time (still based on our deterministic loop time)Will change the required CI jobs soon before/after merge to go from 3.7 + 3.11 to 3.8 + 3.12.
Checklist