Provide client in activity context #740
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
203-activity-client-instance
branch
2 times, most recently
from
1e72703 to
962135c
Compare
dandavison
force-pushed
the
203-activity-client-instance
branch
from
962135c to
3164f69
Compare
cretz
approved these changes
Jan 23, 2025
Co-authored-by: Chad Retz <chad@temporal.io>
|
This needs a bit more work -- as things stand it's attempting to pickle the client in the context in tests of process-based executor pools (which fails when it tries to pickle the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #721