Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support add replica in tcld #337

Merged
merged 4 commits into from
Mar 9, 2024
Merged

Support add replica in tcld #337

merged 4 commits into from
Mar 9, 2024

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Mar 5, 2024

What was changed

Support add replica in tcld

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@yux0 yux0 requested review from mastermanu and laniehei March 5, 2024 21:52
laniehei
laniehei approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@laniehei laniehei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved to not block, but have questions

app/namespace.go Outdated Show resolved Hide resolved
protogen/api/common/v1/message.pb.go Show resolved Hide resolved
app/namespace.go Show resolved Hide resolved
app/namespace.go Show resolved Hide resolved
app/namespace.go Outdated Show resolved Hide resolved
app/namespace.go Show resolved Hide resolved
@yux0 yux0 enabled auto-merge (squash) March 9, 2024 00:39
@yux0 yux0 merged commit e2af5da into main Mar 9, 2024
4 checks passed
@yux0 yux0 deleted the add-replica branch March 9, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laniehei laniehei laniehei approved these changes

@mastermanu mastermanu Awaiting requested review from mastermanu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yux0 @laniehei