User Metadata for Activity and Timers #2529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…. Need to figure out dynamic height of rest of timeline when expanded
Alex-Tideman
requested review from
stevekinney,
rossedfort and
a team
as code owners
Alex-Tideman
commented
Feb 3, 2025
| } | ||
|
|
||
| const onDecode = async () => { | ||
| await tick(); |
There was a problem hiding this comment.
Let it render first, then calc the height
rossedfort
reviewed
Feb 4, 2025
rossedfort
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Users are now able to set User Metadata at the event level (Timers and Activities only for now). This PR will decode and show the User Metadata summary field as the primary label on the Timeline and in the Event History row. If it doesn't exist, fall back to previous primary label (Activity Type, Start to Fire Timeout).
Also includes a lot of cleaning up of unused code, simplifying the Timeline Expanded view so that everything is HTML inside a single SVG ForeignObject instead of multiple. The Payload fields will be stacked vertically and not have large gaps between them.
Screenshots (if applicable) 📸
Updated SS for Status Badge
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?