fix double decoding pending activities #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossedfort
requested review from
stevekinney,
Alex-Tideman and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Alex-Tideman
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
The UI was decoding pending activities twice, once in the workflow run layout, and again when expanding rows in the event history.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Open the UI with a running workflow that has pending a pending activity and verify only 1 call to /decode is made
Sample workflow here: https://github.com/rossedfort/temporal-sample-workflow
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?