Fix asymmetrical padding issue in conv2d #1362
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashokkumarkannan1
force-pushed
the
akannan/conv2d_pad_issue
branch
from
a8f1df8 to
4f636d2
Compare
ashokkumarkannan1
force-pushed
the
akannan/conv2d_pad_issue
branch
from
4f636d2 to
3e4459b
Compare
ashokkumarkannan1
changed the title
|
||||||||||||||
|
||||||||||||||
1 similar comment
|
||||||||||||||
|
||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#682
Problem description
Padding_top must equal padding_bottom for the op to execute as expected
What's changed
Remove xfail statements related to this error in the test files
Updated the fuse_pad_conv2d pass: Added the condition to check asymmetric padding cases.