Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tvm uplift with DictType removed #1371

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

vkovinicTT
Copy link
Member

@vkovinicTT vkovinicTT commented Mar 5, 2025

Removed DictType from TVM because of the uplift as we need to decouple our modules and logic from TVMs.

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.40%. Comparing base (790bbc3) to head (638868c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1371   +/-   ##
=======================================
  Coverage   43.40%   43.40%           
=======================================
  Files          48       48           
  Lines        7860     7860           
=======================================
  Hits         3412     3412           
  Misses       4448     4448           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 6, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests684 ran541 passed143 skipped0 failed
TestResult
No test annotations available

Copy link

github-actions bot commented Mar 6, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests625 ran489 passed136 skipped0 failed
TestResult
No test annotations available

1 similar comment
Copy link

github-actions bot commented Mar 6, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests625 ran489 passed136 skipped0 failed
TestResult
No test annotations available

Copy link

github-actions bot commented Mar 6, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests684 ran541 passed143 skipped0 failed
TestResult
No test annotations available

@vkovinicTT vkovinicTT force-pushed the vkovinic/tvm_remove branch from 071de58 to fa550f3 Compare March 6, 2025 11:45
Copy link

github-actions bot commented Mar 6, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests626 ran487 passed139 skipped0 failed
TestResult
No test annotations available

1 similar comment
Copy link

github-actions bot commented Mar 6, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests626 ran487 passed139 skipped0 failed
TestResult
No test annotations available

Copy link

github-actions bot commented Mar 6, 2025

TestsPassed ☑️Skipped ⚠️Failed ❌️
TT-Forge-FE Tests685 ran540 passed140 skipped5 failed
TestResult
TT-Forge-FE Tests
pytest
test_llama_embedding.test_llama_embedding[openlm-research/open_llama_3b]❌ failure
test_llama_mlp.test_llama_mlp[openlm-research/open_llama_3b]❌ failure
test_llama_rms_norm.test_llama_lm_head[openlm-research/open_llama_3b]❌ failure
test_llama_rotary_emb.test_llama_rotary_emb[openlm-research/open_llama_3b]❌ failure
test_llama_self_attn.test_llama_self_attn[openlm-research/open_llama_3b]❌ failure

Copy link

github-actions bot commented Mar 6, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests685 ran545 passed140 skipped0 failed
TestResult
No test annotations available

1 similar comment
Copy link

github-actions bot commented Mar 6, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests685 ran545 passed140 skipped0 failed
TestResult
No test annotations available

@vkovinicTT vkovinicTT force-pushed the vkovinic/tvm_remove branch from fa550f3 to 4090d15 Compare March 7, 2025 08:32
Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests634 ran493 passed141 skipped0 failed
TestResult
No test annotations available

1 similar comment
Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests634 ran493 passed141 skipped0 failed
TestResult
No test annotations available

@vkovinicTT vkovinicTT force-pushed the vkovinic/tvm_remove branch from 4090d15 to 099cd68 Compare March 7, 2025 09:32
Copy link
Contributor

@nvukobratTT nvukobratTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to link TVM PR to this one as well :))

Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests634 ran493 passed141 skipped0 failed
TestResult
No test annotations available

1 similar comment
Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests634 ran493 passed141 skipped0 failed
TestResult
No test annotations available

Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests693 ran557 passed136 skipped0 failed
TestResult
No test annotations available

1 similar comment
Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests693 ran557 passed136 skipped0 failed
TestResult
No test annotations available

@vkovinicTT vkovinicTT force-pushed the vkovinic/tvm_remove branch from 099cd68 to 5e0db5f Compare March 7, 2025 10:56
Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests634 ran493 passed141 skipped0 failed
TestResult
No test annotations available

1 similar comment
Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests634 ran493 passed141 skipped0 failed
TestResult
No test annotations available

Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests693 ran557 passed136 skipped0 failed
TestResult
No test annotations available

1 similar comment
Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests693 ran557 passed136 skipped0 failed
TestResult
No test annotations available

@vkovinicTT vkovinicTT force-pushed the vkovinic/tvm_remove branch from 5e0db5f to 2f1a185 Compare March 7, 2025 13:08
Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests693 ran557 passed136 skipped0 failed
TestResult
No test annotations available

Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ❌️SkippedFailed
TT-Forge-FE Tests0 ran0 passed0 skipped0 failed
TestResult
No test annotations available

Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests634 ran493 passed141 skipped0 failed
TestResult
No test annotations available

Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests693 ran557 passed136 skipped0 failed
TestResult
No test annotations available

Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests634 ran493 passed141 skipped0 failed
TestResult
No test annotations available

@vkovinicTT vkovinicTT force-pushed the vkovinic/tvm_remove branch from 2f1a185 to 638868c Compare March 7, 2025 15:13
Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests634 ran493 passed141 skipped0 failed
TestResult
No test annotations available

1 similar comment
Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests634 ran493 passed141 skipped0 failed
TestResult
No test annotations available

Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests693 ran557 passed136 skipped0 failed
TestResult
No test annotations available

1 similar comment
Copy link

github-actions bot commented Mar 7, 2025

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests693 ran557 passed136 skipped0 failed
TestResult
No test annotations available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants