Add owner and group field to forge properties #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashokkumarkannan1
requested review from
vkovinicTT,
mstojkovicTT,
nvukobratTT,
pilkicTT and
dgolubovicTT
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1379 +/- ##
=======================================
Coverage 43.40% 43.40%
=======================================
Files 48 48
Lines 7860 7860
=======================================
Hits 3412 3412
Misses 4448 4448 ☔ View full report in Codecov by Sentry. |
|
||||||||||||||
|
||||||||||||||
|
||||||||||||||
|
||||||||||||||
nvukobratTT
reviewed
Mar 6, 2025
There was a problem hiding this comment.
Looks good, let's just cleanup these priorities.
In sum, each priority model will be only a single requested variant of that model. I shared two docs in a comment to help you out with determining eact details. Please feel free to share it with the rest of the team, and let me know if some details are missing that are required for us.
ashokkumarkannan1
force-pushed
the
akannan/owner_and_group
branch
from
3d3888a to
31ee499
Compare
|
||||||||||||||
1 similar comment
|
||||||||||||||
|
||||||||||||||
1 similar comment
|
||||||||||||||
ashokkumarkannan1
force-pushed
the
akannan/owner_and_group
branch
from
31ee499 to
b5487ec
Compare
|
||||||||||||||
1 similar comment
|
||||||||||||||
nvukobratTT
approved these changes
Mar 7, 2025
|
||||||||||||||
1 similar comment
|
||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
What's changed