Update tvm commit hash retrieval for out-of-tree execution #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tvm cache path retrieval assumed execution within the Forge tree, causing an error when run out-of-tree as the tvm submodule could not be found. This change modifies the commit hash retrieval method to use the path from `tvm.__file__`, allowing the cache to be saved correctly even in out-of-tree scenarios.
sott0n
requested review from
nvukobratTT,
pilkicTT and
dgolubovicTT
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1393 +/- ##
=======================================
Coverage 43.40% 43.40%
=======================================
Files 48 48
Lines 7860 7860
=======================================
Hits 3412 3412
Misses 4448 4448 ☔ View full report in Codecov by Sentry. |
|
||||||||||||||
1 similar comment
|
||||||||||||||
|
||||||||||||||
1 similar comment
|
||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
N/A
Problem description
The tvm cache path retrieval assumed execution within the Forge tree, causing an error when run out-of-tree as the tvm submodule could not be found.
What's changed
This change modifies the commit hash retrieval method to use the path from
tvm.__file__, allowing the cache to be saved correctly even in out-of-tree scenarios.Checklist