Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Workaround VLLM's arguments in benchmarking #93

Open
ppetrovicTT opened this issue Feb 3, 2025 · 0 comments
Open

Fix/Workaround VLLM's arguments in benchmarking #93

ppetrovicTT opened this issue Feb 3, 2025 · 0 comments

Comments

@ppetrovicTT
Copy link
Collaborator

VLLM's benchmarking needs to be patched with benchmarking/benchmark_serving.patch.
Otherwise it complains for bad usage of some arguments (best-of and logprobes).

We should either fix it in our fork of VLLM, or obviate it with proper support for the options it removes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ppetrovicTT