Patch VLLM when building Docker #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstescoTT
reviewed
Feb 3, 2025
| @@ -115,6 +115,10 @@ COPY --chown=${CONTAINER_APP_USERNAME}:${CONTAINER_APP_USERNAME} "locust" "${APP | |||
| RUN /bin/bash -c "source ${PYTHON_ENV_DIR}/bin/activate \ | |||
| && pip install --default-timeout=240 --no-cache-dir -r requirements.txt" | |||
|
|
|||
| # apply patch to remove best-of argument from vllm | |||
| WORKDIR ${vllm_dir} | |||
| RUN git apply ${APP_DIR}/benchmarking/benchmark_serving.patch | |||
There was a problem hiding this comment.
The patch file is meant to be temporary, if we're going to be using it longer then we should just add the patch to our vLLM fork, or obviate it with proper support for the options it removes.
There was a problem hiding this comment.
I added this with the intention to streamline the user experience, as it's currently one manual step in order to run the benchmarks. I thought since it's in this repository, that it's purpose was to workaround VLLM change.
All good! I'll reject this PR.
I created an issue as well: #93
|
Created an issue for a proper fix: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.