Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#17863: Add sweep test for Batch Norm #18688

Merged
merged 2 commits into from
Mar 9, 2025
Merged

Conversation

VirdhatchaniKN
Copy link
Contributor

@VirdhatchaniKN VirdhatchaniKN commented Mar 6, 2025

Ticket

#17863

Problem description

Add sweep test for BN

What's changed

  • Added sweep test for BN totest for inference mode and training mode
Screenshot 2025-03-06 at 10 06 28 AM
  • Added a test_batch_norm method to test locally via pytest
Screenshot 2025-03-07 at 11 44 23 PM

Checklist

@VirdhatchaniKN VirdhatchaniKN linked an issue Mar 6, 2025 that may be closed by this pull request
@VirdhatchaniKN VirdhatchaniKN force-pushed the virdhatchani/sweep_BN branch from 82a0b62 to d948603 Compare March 6, 2025 07:02
@VirdhatchaniKN VirdhatchaniKN force-pushed the virdhatchani/fpu_bn_hang branch from adfebf2 to dbb139b Compare March 6, 2025 09:16
@VirdhatchaniKN VirdhatchaniKN force-pushed the virdhatchani/sweep_BN branch from 387f1ba to 8c9653a Compare March 6, 2025 13:54
@VirdhatchaniKN VirdhatchaniKN force-pushed the virdhatchani/fpu_bn_hang branch from dbb139b to c4d5a9c Compare March 6, 2025 16:46
@VirdhatchaniKN VirdhatchaniKN force-pushed the virdhatchani/sweep_BN branch 4 times, most recently from c775e4d to b17a5aa Compare March 6, 2025 17:58
@VirdhatchaniKN VirdhatchaniKN force-pushed the virdhatchani/fpu_bn_hang branch from c4d5a9c to dc3aed0 Compare March 7, 2025 01:53
Base automatically changed from virdhatchani/fpu_bn_hang to main March 7, 2025 02:09
@VirdhatchaniKN VirdhatchaniKN force-pushed the virdhatchani/sweep_BN branch 4 times, most recently from b559ab5 to 81dbc2d Compare March 7, 2025 06:57
@VirdhatchaniKN VirdhatchaniKN requested a review from bbradelTT March 7, 2025 07:00
@VirdhatchaniKN VirdhatchaniKN marked this pull request as ready for review March 7, 2025 07:01
}


def run(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test_batch_norm method to test locally via pytest.

See tests/sweep_framework/sweeps/matmul/short/matmul_traces.py
for an example.

@VirdhatchaniKN VirdhatchaniKN force-pushed the virdhatchani/sweep_BN branch from 81dbc2d to 34d1d31 Compare March 7, 2025 15:20
@VirdhatchaniKN VirdhatchaniKN force-pushed the virdhatchani/sweep_BN branch 2 times, most recently from 1570c9e to 57ed0ca Compare March 8, 2025 06:14
Copy link
Contributor

@sjameelTT sjameelTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run the sweep on pipelines?

@VirdhatchaniKN VirdhatchaniKN force-pushed the virdhatchani/sweep_BN branch from 57ed0ca to 33f3e88 Compare March 9, 2025 08:28
@VirdhatchaniKN
Copy link
Contributor Author

@VirdhatchaniKN VirdhatchaniKN merged commit 025fdaa into main Mar 9, 2025
160 checks passed
@VirdhatchaniKN VirdhatchaniKN deleted the virdhatchani/sweep_BN branch March 9, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep test for Batch Norm
3 participants