Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grim/explorer memory vis #2319

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Grim/explorer memory vis #2319

wants to merge 19 commits into from

Conversation

jgrimTT
Copy link

@jgrimTT jgrimTT commented Feb 27, 2025

Ticket

Link to Github Issue

Problem description

Creating the memory visualization function.

Copy link
Contributor

@vprajapati-tt vprajapati-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Overall some changes requested on where in the code the attribute gets added in.

I know for each op we collect the attributes in the get_attributes function, but you should be able to expose the attribute list to some helper functions and append them using these helper functions. In the OpHandler add a function add_attribute and call this before the line graph_node = operation.make_graph_node() to add the Memory attributes (if present).

@jgrimTT jgrimTT enabled auto-merge (squash) March 4, 2025 20:37
@jgrimTT jgrimTT requested a review from vprajapati-tt March 9, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add memory report visualization into tt explorer
2 participants