-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grim/explorer memory vis #2319
base: main
Are you sure you want to change the base?
Grim/explorer memory vis #2319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Overall some changes requested on where in the code the attribute gets added in.
I know for each op we collect the attributes in the get_attributes function, but you should be able to expose the attribute list to some helper functions and append them using these helper functions. In the OpHandler
add a function add_attribute
and call this before the line graph_node = operation.make_graph_node()
to add the Memory attributes (if present).
Ticket
Link to Github Issue
Problem description
Creating the memory visualization function.