Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TTNN verification and add tests for conv2d op #2351

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor TTNN verification and add tests for conv2d op #2351

wants to merge 1 commit into from

Conversation

jserbedzijaTT
Copy link
Contributor

Ticket

Link to Github Issue

Problem description

The TTNN verification was previously reverted in this commit to unblock the uplift of frontends. This PR restores the verification while improving test coverage.

What's changed

  • Reintroduce the reverted TTNN verification
  • Add positive and negative tests for Conv2D TTNN verification
  • Update the description for conv2d in tablegen files

@jserbedzijaTT jserbedzijaTT force-pushed the jserbedzija/conv2d_ttnn_verification branch from 0e0ddac to d61348e Compare March 3, 2025 17:22
azecevicTT
azecevicTT approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@azecevicTT azecevicTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Few comments, most of them are applicable in multiple places, but they are mostly nits.

@jserbedzijaTT jserbedzijaTT force-pushed the jserbedzija/conv2d_ttnn_verification branch 4 times, most recently from 32643f7 to 7838d29 Compare March 6, 2025 10:36
sdjordjevicTT
sdjordjevicTT approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@sdjordjevicTT sdjordjevicTT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Please make sure to run FE PR CIs before merging this :)

@jserbedzijaTT jserbedzijaTT force-pushed the jserbedzija/conv2d_ttnn_verification branch from 7838d29 to be42c3f Compare March 7, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdjordjevicTT sdjordjevicTT sdjordjevicTT approved these changes

@azecevicTT azecevicTT azecevicTT approved these changes

@svuckovicTT svuckovicTT Awaiting requested review from svuckovicTT svuckovicTT is a code owner

@mtopalovicTT mtopalovicTT Awaiting requested review from mtopalovicTT mtopalovicTT is a code owner

@jnie-TT jnie-TT Awaiting requested review from jnie-TT jnie-TT is a code owner

@nsmithtt nsmithtt Awaiting requested review from nsmithtt

@mrakitaTT mrakitaTT Awaiting requested review from mrakitaTT mrakitaTT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jserbedzijaTT @sdjordjevicTT @azecevicTT