Use op.operation.name to detect funcOps in tt-explorer #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vwellsTT
requested review from
odjuricicTT,
tt-mpantic,
sdjordjevicTT,
vprajapati-tt and
vcanicTT
as code owners
vwellsTT
changed the title
vwellsTT
commented
Mar 3, 2025
| @@ -771,7 +738,7 @@ def process_operations( | |||
| # Second pass: create all edges | |||
| for op in operations: | |||
| # Skip module + func operations as they've been processed recursively | |||
| if is_module_op(op) or op.name == "func.func": | |||
| if is_module_op(op): | |||
There was a problem hiding this comment.
this was wrong before, we do want to process operands on func ops, only want to avoid emitting a node for them (which is governed by other check, not this one). Otherwise, inputs arguments don't get nodes -> missing a lot of edges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
In previous PR, I was not properly checking for funcOps to avoid extraneous node in tt-explorer (because
op.namewill yield actual func name,op.operation.namewill yield expected "func.func"). This is trivial fix to correct this logic, plus simplify call structure a bit based on Vraj's feedbackWhat's changed
Inlined one of the funcs I created, since it is only invoked once anyway + didn't add much clarity. Replaced relevant comparisons to "func.func" with
op.operation.nameinstead ofop.nameChecklist