[EmitC] Add Conv2D to EmitC op conversion #2365
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserbedzijaTT
force-pushed
the
jserbedzija/conv2d_to_emitc_op_conversion
branch
from
ca2c603 to
4b341e7
Compare
jserbedzijaTT
changed the title
jserbedzijaTT
force-pushed
the
jserbedzija/conv2d_to_emitc_op_conversion
branch
from
4b341e7 to
94fa96a
Compare
azecevicTT
force-pushed
the
jserbedzija/conv2d_to_emitc_op_conversion
branch
from
94fa96a to
4d9846f
Compare
svuckovicTT
reviewed
Mar 6, 2025
| @@ -681,6 +723,24 @@ class EmitCTTNNEmitter { | |||
| template <typename OpConversionPatternTy> | |||
| emitc::CallOpaqueOp replaceOp(OpConversionPatternTy &&opConversionPattern, | |||
| llvm::ArrayRef<mlir::Attribute> args) { | |||
| if constexpr (std::is_same_v<TTNNOp, tt::ttnn::Conv2dOp> || | |||
There was a problem hiding this comment.
Add comment explaining why this special treatment.
| @@ -0,0 +1,16 @@ | |||
| // RUN: ttmlir-opt --ttir-to-ttnn-backend-pipeline="system-desc-path=%system_desc_path%" %s > %t.mlir | |||
There was a problem hiding this comment.
Let's put this into pooling dir instead of conv2d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
What's changed
Added Conv2D to EmitC op conversion using the new TTNN→EmitC op conversion infrastructure created by @azecevicTT.