-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add constraints and runtime API to typecast #2380
base: main
Are you sure you want to change the base?
Conversation
34e107c
to
8d4f538
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dialect changes LGTM.
|
||
const auto inputShape = getInput().getType().getShape(); | ||
const auto outputShape = | ||
mlir::cast<RankedTensorType>(getResult().getType()).getShape(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: unnecessary cast
|
||
const auto inputShape = getInput().getType().getShape(); | ||
const auto outputShape = | ||
mlir::cast<RankedTensorType>(getResult().getType()).getShape(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here as well.
Ticket
#2315
Problem description
The optimizer needs more ops with constraints and runtime support to be able to ingest real models. Typecast is used in resnet (#2277)
What's changed
Added constraints and runtime API support for typecast. Added unit tests for the new APIs
Closes #2315
Checklist