Fix maxpool2d signature + add emitc conversion&test #2385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svuckovicTT
requested review from
mtopalovicTT,
sdjordjevicTT,
azecevicTT,
jserbedzijaTT,
jnie-TT,
kmabeeTT,
AleksKnezevic and
pilkicTT
as code owners
azecevicTT
approved these changes
Mar 6, 2025
| @@ -1246,16 +1246,31 @@ class MaxPool2dOpConversionPattern | |||
| outputType.getElementType(), | |||
| outputType.getEncoding()); | |||
|
|
|||
| DenseI32ArrayAttr kernelSizeAttr = rewriter.getDenseI32ArrayAttr( | |||
| {static_cast<int32_t>(adaptor.getKernelHeight()), | |||
There was a problem hiding this comment.
Shouldn't all of these already be int32_t?
| std::array{op->dilation_height(), op->dilation_width()}, | ||
| outputMemoryConfig, std::nullopt); | ||
| op->channels(), kernelSize, stride, padding, dilation, std::nullopt, | ||
| std::nullopt, op->ceil_mode()); |
There was a problem hiding this comment.
Nit: add parameter names for std::nullopt.
svuckovicTT
requested review from
mrakitaTT,
mmanzoorTT and
wooseokTT
as code owners
mmanzoorTT
approved these changes
Mar 6, 2025
|
@jnie-TT @kmabeeTT @AleksKnezevic leaving for a week-long vacation today, would be great if I could check this in before that, need your approval for the |
kmabeeTT
approved these changes
Mar 7, 2025
odjuricicTT
pushed a commit
that referenced
this pull request
Mar 8, 2025
### Ticket #2328 ### Problem description Maxpool2d is not supported thru emitc. ### What's changed - Changed MaxPool2d signature in TTNN dialect to match signature of lib. - Added conversion TTNN->EmitC - Added test ### Checklist - [x] New/Existing tests provide coverage for changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#2328
Problem description
Maxpool2d is not supported thru emitc.
What's changed
Checklist