[Chip] Move TTDevice to local chip (#396)

### Issue
Related to #351 

### Description
Another PR in a push to define Chip class properly.
This PR moves tt_device under Chip, specifically under LocalChips.

### List of the changes
- Add TTDevice to LocalChip
- Renamed all_chips, target_chips and remote_chips to have more
consistent naming.
- MockChip disabled at the moment, it will start working by itself at
some point, when enough stuff is moved to Chip class.

### Testing
Existing tests

### API Changes
There are no API changes in this PR.

device/api/umd/device/chip/chip.h

@@ -11,6 +11,8 @@
 
 namespace tt::umd {
 
+class TTDevice;
+
 // An abstract class that represents a chip.
 class Chip {
 public:
@@ -20,6 +22,8 @@ class Chip {
 
     tt_SocDescriptor& get_soc_descriptor();
 
+    virtual TTDevice* get_tt_device();
+
     virtual bool is_mmio_capable() const = 0;
 
 private:

device/api/umd/device/chip/local_chip.h

@@ -11,7 +11,13 @@
 namespace tt::umd {
 class LocalChip : public Chip {
 public:
-    LocalChip(tt_SocDescriptor soc_descriptor);
+    LocalChip(tt_SocDescriptor soc_descriptor, int pci_device_id);
+
+    TTDevice* get_tt_device() override;
+
     bool is_mmio_capable() const override;
+
+private:
+    std::unique_ptr<TTDevice> tt_device_;
 };
 }  // namespace tt::umd

device/api/umd/device/cluster.h

@@ -311,20 +311,6 @@ class tt_device {
         throw std::runtime_error("---- tt_device::translate_to_noc_table_coords is not implemented\n");
     }
 
-    /**
-     * Get the total number of chips in the cluster based on the network descriptor.
-     */
-    virtual int get_number_of_chips_in_cluster() {
-        throw std::runtime_error("---- tt_device::get_number_of_chips_in_cluster is not implemented\n");
-    }
-
-    /**
-     * Get the logical ids for all chips in the cluster
-     */
-    virtual std::unordered_set<chip_id_t> get_all_chips_in_cluster() {
-        throw std::runtime_error("---- tt_device::get_all_chips_in_cluster is not implemented\n");
-    }
-
     /**
      * Get cluster descriptor object being used in UMD instance.
      */
@@ -621,13 +607,12 @@ class Cluster : public tt_device {
     virtual bool using_harvested_soc_descriptors();
     virtual std::unordered_map<chip_id_t, uint32_t> get_harvesting_masks_for_soc_descriptors();
     virtual void translate_to_noc_table_coords(chip_id_t device_id, std::size_t& r, std::size_t& c);
-    virtual int get_number_of_chips_in_cluster();
-    virtual std::unordered_set<chip_id_t> get_all_chips_in_cluster();
     virtual tt_ClusterDescriptor* get_cluster_description();
     static int detect_number_of_chips();
     static std::vector<chip_id_t> detect_available_device_ids();
     virtual std::set<chip_id_t> get_target_mmio_device_ids();
     virtual std::set<chip_id_t> get_target_remote_device_ids();
+    virtual std::set<chip_id_t> get_target_device_ids();
     virtual std::map<int, int> get_clocks();
     virtual void* host_dma_address(std::uint64_t offset, chip_id_t src_device_id, uint16_t channel) const;
     virtual std::uint64_t get_pcie_base_addr_from_device(const chip_id_t chip_id) const;
@@ -803,14 +788,12 @@ class Cluster : public tt_device {
     tt_driver_noc_params noc_params;
     tt_driver_eth_interface_params eth_interface_params;
     std::vector<tt::ARCH> archs_in_cluster = {};
-    std::set<chip_id_t> target_devices_in_cluster = {};
-    std::set<chip_id_t> target_remote_chips = {};
-    std::set<chip_id_t> all_target_mmio_devices = {};
+    std::set<chip_id_t> all_chip_ids_ = {};
+    std::set<chip_id_t> remote_chip_ids_ = {};
+    std::set<chip_id_t> local_chip_ids_ = {};
     std::unordered_map<chip_id_t, std::unique_ptr<Chip>> chips_;
     tt::ARCH arch_name;
 
-    // Map of enabled tt devices
-    std::unordered_map<chip_id_t, std::unique_ptr<TTDevice>> m_tt_device_map;
     std::shared_ptr<tt_ClusterDescriptor> cluster_desc;
 
     // remote eth transfer setup

device/chip/chip.cpp

@@ -12,4 +12,6 @@ Chip::Chip(tt_SocDescriptor soc_descriptor) : soc_descriptor_(soc_descriptor) {}
 
 tt_SocDescriptor& Chip::get_soc_descriptor() { return soc_descriptor_; }
 
+TTDevice* Chip::get_tt_device() { return nullptr; }
+
 }  // namespace tt::umd

device/chip/local_chip.cpp

@@ -6,9 +6,14 @@
 
 #include "umd/device/chip/local_chip.h"
 
+#include "umd/device/tt_device/tt_device.h"
+
 namespace tt::umd {
 
-LocalChip::LocalChip(tt_SocDescriptor soc_descriptor) : Chip(soc_descriptor) {}
+LocalChip::LocalChip(tt_SocDescriptor soc_descriptor, int pci_device_id) :
+    Chip(soc_descriptor), tt_device_(TTDevice::create(pci_device_id)) {}
+
+TTDevice* LocalChip::get_tt_device() { return tt_device_.get(); }
 
 bool LocalChip::is_mmio_capable() const { return true; }
 }  // namespace tt::umd

device/chip/mock_chip.cpp

@@ -10,5 +10,5 @@ namespace tt::umd {
 
 MockChip::MockChip(tt_SocDescriptor soc_descriptor) : Chip(soc_descriptor) {}
 
-bool MockChip::is_mmio_capable() const { return true; }
+bool MockChip::is_mmio_capable() const { return false; }
 }  // namespace tt::umd