Implement wait for Blackhole DRAM training #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanevskiTT
commented
Feb 25, 2025
| @@ -94,4 +95,56 @@ void LocalChip::wait_eth_cores_training(const uint32_t timeout_ms) { | |||
| } | |||
| } | |||
|
|
|||
| void LocalChip::wait_dram_cores_training(const uint32_t timeout_ms) { | |||
There was a problem hiding this comment.
Blackhole CI timed out as expected, don't merge the PR until the CI passes
pjanevskiTT
commented
Feb 26, 2025
broskoTT
approved these changes
Feb 28, 2025
pjanevskiTT
force-pushed
the
pjanevski/bh_dram_training
branch
from
0f2df6f to
9bc2211
Compare
pjanevskiTT
force-pushed
the
pjanevski/bh_dram_training
branch
from
47891d5 to
e7bc2ba
Compare
pjanevskiTT
force-pushed
the
pjanevski/bh_dram_training
branch
from
e7bc2ba to
b206855
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#478
Note: the PR is probably going to timeout on Blackhole CI until the fw from the syseng is released, so reviewers can do the review without me checking this in, to be ready when the fw is released.
Description
Implement waiting for DRAM training on Blackhole. Format of the data provided by syseng to sw is described in https://tenstorrent.atlassian.net/browse/SYS-1241. This PR integrates the wait in our code according to the proposed ticket design.
List of the changes
Testing
CI
API Changes
/