Remove cluster descriptor API from public #578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanevskiTT
changed the title
pjanevskiTT
commented
Mar 6, 2025
| @@ -98,7 +100,6 @@ class tt_ClusterDescriptor { | |||
| // get_cluster_descriptor_file_path will create ethernet map in the background. | |||
| static std::string get_cluster_descriptor_file_path(); | |||
There was a problem hiding this comment.
Don't merge the PR until this is also moved to private. We have alternative for that in Cluster as well
pjanevskiTT
changed the title
|
Closing this in favour of upcoming UBB PR, this will hide evertything that is needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Cluster descriptor create API always calls create-ethernet-map. This lib does not work for BH, UBB...This API should be moved from public and all calls should go through
Cluster::create_cluster_descriptor.Description
Only public accessible API for creating cluster descriptor from silicon should be
Cluster::create_cluster_descriptor. Make all tests use this API and remove create-ethernet-map call from public API.List of the changes
tt_ClusterDescriptor::create()from publicTesting
CI
API Changes
tt_ClusterDescriptor::create()is not public anymore - switch all clients toCluster::create_cluster_descriptor()